Re: (bib) libobjc build failure

[Zack Weinberg <zack at codesourcery dot com>]

Zack Weinberg <zack@codesourcery.com> writes:
> Nathanael Nerode <neroden@twcny.rr.com> writes:
>> On b-i-b (i686-pc-linux-gnu), I'm getting a failure to build libobjc; 
>> it's complaining that BITS_PER_UNIT is not defined in "encoding.c".
>
> This did not happen to me when I tested the patch.  I am trying to
> reproduce the problem now.

I have reproduced the problem and devised a fix.  I am getting a lot
of testsuite failures of the form

libobjc.a(thr-objc.o)(.text+0x46): In function `__objc_init_thread_system':
gcc/gthr-posix.h:129: undefined reference to `pthread_key_create'

for no apparent reason.  However, the appended patch improves the
situation, so I've gone ahead and checked it in.  Help wanted.

zw

        * encoding.c, sendmsg.c: Include coretypes.h and tm.h.

===================================================================
Index: libobjc/encoding.c
--- libobjc/encoding.c	2 Jul 2002 19:42:06 -0000	1.17
+++ libobjc/encoding.c	2 Dec 2002 07:11:51 -0000
@@ -27,7 +27,11 @@ Boston, MA 02111-1307, USA.  */
    This exception does not however invalidate any other reasons why
    the executable file might be covered by the GNU General Public License.  */
 
+/* FIXME: This file has no business including tm.h.  */
+
 #include "tconfig.h"
+#include "coretypes.h"
+#include "tm.h"
 #include "objc-api.h"
 #include "encoding.h"
 #include <stdlib.h>
===================================================================
Index: libobjc/sendmsg.c
--- libobjc/sendmsg.c	17 Sep 2002 22:59:39 -0000	1.8.4.1
+++ libobjc/sendmsg.c	2 Dec 2002 07:11:51 -0000
@@ -25,7 +25,11 @@ Boston, MA 02111-1307, USA.  */
    however invalidate any other reasons why the executable file might be
    covered by the GNU General Public License.  */
 
+/* FIXME: This file has no business including tm.h.  */
+
 #include "tconfig.h"
+#include "coretypes.h"
+#include "tm.h"
 #include "runtime.h"
 #include "sarray.h"
 #include "encoding.h"