This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tree-ssa] Problem in right-assocify
- From: Jason Merrill <jason at redhat dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Sat, 30 Nov 2002 00:26:20 -0500
- Subject: Re: [tree-ssa] Problem in right-assocify
- References: <u8ptsoiwdt.fsf@gromit.moeb> <u8isygiupg.fsf@gromit.moeb>
On Fri, 29 Nov 2002 10:36:11 +0100, Andreas Jaeger <aj@suse.de> wrote:
> Andreas Jaeger <aj@suse.de> writes:
>
>> Looking at this warning:
>> /cvs/gcc-tree-ssa-20020619-branch/gcc/tree-simple.c:880: warning: unused variable `rhs'
>>
>> I noticed that either the comment is wrong and this variable is really
>> unused - or there's a typo. Could somebody please check whether the
>> patch below is the right think to do - and then approve it or tell me
>> what to do?
>
> The patch is definitly wrong - bootstrap fails with it. But the
> question remains whether the comment is right or should be updated and
> why rhs is unused,
The comment is accurate, but misleading in the presence of a variable named
'rhs'; "op1" would be clearer. Removing the variable should also help.
Jason