This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Universal Character Names, v2
- From: Neil Booth <neil at daikokuya dot co dot uk>
- To: "Martin v. L?wis" <martin at v dot loewis dot de>
- Cc: gcc-patches at gcc dot gnu dot org, java at gcc dot gnu dot org
- Date: Fri, 29 Nov 2002 07:06:55 +0000
- Subject: Re: Universal Character Names, v2
- References: <200211282334.gASNYdTA004058@mira.informatik.hu-berlin.de>
Martin v. L?wis wrote:-
> This is the second version of my UCN patch. It incorporates all
> comments from the previous patch (AFAIR).
>
> Specifically, the changes relative to the previous patch are:
> - Update character sets for C99, and C++ DR 131.
> - Support escaped newlines in the middle of an UCN. This is done
> through the addition of maybe_read_ucs_reader function, which
> uses get_effective_char internally.
You should find a way to share code here; duplicating most of
maybe_read_ucs is not ideal. Nothing says maybe_read_ucs has to
remain in it's current form.
Also, I don't think you've covered all cases for escaped newlines;
I saw at least one place where you just read the next character directly.
Neil.