This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Remove unnecessary casts in gcc/java
Jens-Michael Hoffmann writes:
> Andrew Haley writes:
>
> > > 2002-11-14 Jens-Michael Hoffmann <jensmh@gmx.de>
> > >
> > > * buffer.c: Remove unnecessary casts.
> > > * check-init.c: Likewise.
> > > * class.c: Likewise.
> > > * constants.c: Likewise.
> > > * decl.c: Likewise.
> > > * except.c: Likewise.
> > > * gjavah.c: Likewise.
> > > * jcf-io.c: Likewise.
> > > * jcf-parse.c: Likewise.
> > > * jcf-path.c: Likewise.
> > > * jvspec.c: Likewise.
> > > * lang.c: Likewise.
> > > * lex.c: Likewise.
> > > * verify.c: Likewise.
> >
> > This is OK.
> >
> > Your patch did not apply because of spurious line breaks. They
> > weren't caused by the mailer, so I guess it was a cut 'n paste error.
>
> I created the patch with the command
> cvs -q -z 9 update -dP; cvs -q -z 9 diff -c3p > patch. Then I used emacs to
> remove the first lines of that file which contained some output from cvs.
> Maybe emacs has added some linebreaks.
I don't think so. Emacs is *very* good at this sort of thing.
> Then I put the resulting file in the email.
Well, it depends how you did that step. It's important to get this
fixed before sending patches.
You could extract the patch from the mail you sent and compare it with
your original file.
> What can I do to get that patch installed?
I'll do it if you don't have write access.
Thanks,
Andrew.