This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: C++ PATCH: PR c++/7228
- From: Mark Mitchell <mark at codesourcery dot com>
- To: David Edelsohn <dje at watson dot ibm dot com>, Mike Stump <mrs at apple dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 24 Oct 2002 16:29:12 -0700
- Subject: Re: C++ PATCH: PR c++/7228
--On Wednesday, October 23, 2002 10:40:48 PM -0400 David Edelsohn
<dje@watson.ibm.com> wrote:
A patch to add the guards is appended, but if those macros always
should be guarded with a test that the lang_type structure exists, then it
probably should be subsumed into the macro and separate
SET_CLASSTYPE_... macros created for setting the fields. Having to
remember to test for the lang_type structure is errorprone, as this PR
demonstrates.
Yes, that is what we should do. If you do that, and tests pass, that
patch is pre-approved.
Thanks for stepping in to help with this C++ PR!
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com