This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: More SH patches for the 3.2 branch


On Wed, Oct 16, 2002 at 10:49:30AM -0700, Mark Mitchell wrote:
> 
> >Are these OK?
> 
> Are they regressions?
> 
> If so, it's OK to move them to the branch.  If not, it's not OK.

On Wed, Oct 16, 2002 at 12:50:37PM -0400, Daniel Jacobowitz wrote:
> I think that this patch should be moved to the branch:
> 
> # Subject: bug fix for calls.c:expand_call
>   http://gcc.gnu.org/ml/gcc-patches/2002-04/msg01448.html
> 
> Without it we miscompile expr.c:store_constructor_fields by creating an
> illegal sibcall to store_field.  The resulting GCC will run, but crashes on
> any call to store_constructor_field.

This one is a regression.  I've committed it.

> While searching the archives for that patch, I also noticed:
> 
> # Subject: bug fix for loop.c:load_mems
>   http://gcc.gnu.org/ml/gcc-patches/2002-04/msg01447.html
> 
> which also looks like a good candidate for the branch.

I think this one is also but I don't have a testcase for it, so I left
it out.

Thanks, Mark.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]