This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fix ObjC protocol qualification lossage


Ziemowit Laski wrote:-

>         * c-lang.c (is_id): New stub.

I'd prefer objc-specific functions exported to the C front end
retain an objc_ prefix like the others do.

> + tree
> + is_id (ident)
> +      tree ident;
> + {
> +   /* NB: This function may be called before the ObjC front-end
> +      has been initialized, in which case ID_TYPE will be NULL. */
> +   return (id_type && ident && TYPE_P (ident) && IS_ID (ident))
> +         ? id_type
> +         : NULL_TREE;
>   }

Not important, but doesn't this comment mean that "id_type && "
is redundant?

Neil.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]