This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/RFA] Make *_DEBUGGING_INFO defines consistent




--On Thursday, August 29, 2002 09:16:48 AM -0700 Jason R Thorpe <thorpej@wasabisystems.com> wrote:

The vast majority of places that define *_DEBUGGING_INFO do it like so:

#define DBX_DEBUGGING_INFO

However, a few define with a value, e.g.:

#define DBX_DEBUGGING_INFO 1

Defining with a value is unnecessary, and causes "redefined" warnings on
e.g. the mips-netbsd target (because elfos.h is included before
mips/elf.h).

The following patch makes them all consistent (i.e. no value).  OK to
commit?
No; let's go the other direction.

We want to be able to write:

 if (DBX_DEBUGGING_INFO) {
   ...
 }

as per our coding standards.

A patch to make them consistent in that way is pre-approved.

Thanks,

--
Mark Mitchell                mark@codesourcery.com
CodeSourcery, LLC            http://www.codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]