This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed patch [was : PATCH: Protocol Warning]
- From: Jason Merrill <jason at redhat dot com>
- To: Devang Patel <dpatel at apple dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 20 Aug 2002 23:12:53 +0100
- Subject: Re: Unreviewed patch [was : PATCH: Protocol Warning]
- References: <09F5A0B8-B469-11D6-A5B3-00039310EDEA@apple.com>
On Tue, 20 Aug 2002 11:17:08 -0700, Devang Patel <dpatel@apple.com> wrote:
> On Tuesday, August 20, 2002, at 09:45 AM, Jason Merrill wrote:
>
>> This seems harmless to me, but I'm curious as to how a type with a
>> different TYPE_CONTEXT can have the same TYPE_MAIN_VARIANT.
> objc-act.h:106:#define TYPE_PROTOCOL_LIST(TYPE) ((TYPE)->type.context)
Ah, so it isn't TYPE_CONTEXT at all, ObjC has changed the meaning of that
field. That seems dangerous; there are lots of things in the backend that
expect TYPE_CONTEXT to be the context of the type. The debugging backends
in particular. But it's been there since the dawn of time, so I guess your
patch is OK.
Jason