This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Minor fix to libstdc++-v3/testsuite/Makefile.in
On Mon, Aug 05, 2002 at 06:32:13PM -0700, Ziemowit Laski wrote:
>
> On Monday, Aug 5, 2002, at 18:28 US/Pacific, Phil Edwards wrote:
>
> >On Mon, Aug 05, 2002 at 06:22:31PM -0700, Ziemowit Laski wrote:
> >>and no tests would be run. Upon further investigation, I discovered
> >>that `runtest' _was_ in fact invoked, but complained about not being
> >>able to find init.tcl. This, in turn, was due to TCL_LIBRARY not
> >>being set as it should have been.
> >
> >Yes. This is working as designed. If you're going to set TCL_LIBRARY,
> >you must set it correctly.
> >
> >
> >> * testsuite/Makefile.in(check-DEJAGNU): Correct the relative
> >>path
> >> to 'expect' so that TCL_LIBRARY gets set. Fix warning
> >>message.
> >
> >I don't think this patch is correct, for two reasons: first, the
> >relative
> >path is wrong. Second, Makefile.in is generated from Makefile.am (see
> >the comments at the very start of the files).
>
> My bad about not modifying Makefile.am; but why do you say the relative
> path
> is wrong? What should it be?
If you look at Makefile.am you'll see that $(EXPECT) finds expect in
the right location. $(top_builddir) is `..' so ../../expect/expect is
where the built expect binary ought to be; why isn't it right for you?
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer