This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Remove <varargs.h> support, revised
On Mon, Jul 15, 2002 at 05:20:05PM -0700, Richard Henderson wrote:
> On Mon, Jul 15, 2002 at 04:01:17PM -0700, Zack Weinberg wrote:
> > std_expand_builtin_va_start (stdarg_p, valist, nextarg)
> > - int stdarg_p;
> > + int stdarg_p ATTRIBUTE_UNUSED;
>
> Should remove the argument rather than ignore it universally.
I explained this in the original message - removing the argument would
have required me to make mechanical changes to lots more files. I
would prefer to do that in a separate patch (possibly at the same time
as converting these to targetm hooks).
...
> > -#define __va_copy(d,s) __builtin_va_copy((d),(s))
> > +#define __va_copy(d,s) __builtin_va_copy(d,s)
>
> Incorrect removal of argument protection parenthesis.
Explain? Unless I am seriously confused, argument protection
parentheses are never necessary when you are simply renaming a
function call.
> > Index: testsuite/gcc.c-torture/execute/va-arg-15.c
>
> How many of these are redundant with existing stdarg tests?
Zero. I already checked that.
zw