This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: 3.1.1 PATCH: Fix libstdc++-v3 isprint for Solaris 2.5.1


Phil Edwards writes:

> This looks okay for the trunk.  Mark's call for the branch.  (I'd vote yes,
> since the bug and this change are only on a single platform, and it isn't one
> of the primary platforms.)

ok, I've Cc'ed him to get approval or rejection for the branch:

	http://gcc.gnu.org/ml/gcc-patches/2002-07/msg00594.html

> However...
> 
> > Sat Jul 13 02:15:14 2002  Rainer Orth  <ro@TechFak.Uni-Bielefeld.DE>
> > 
> > 	* config/os/solaris/solaris2.5/bits/ctype_base.h (ctype_base):
> > 	Fix.
> 
> 1)  Aren't date formats supposed to be different than that?

Not really: while emacs 20 and up uses the ISO-8601 format, emacs 19 uses
the traditional ctime format.  You still see both in recent gcc ChangeLogs.
Since I'm still using emacs 19.34, my posted ChangeLog entries are in the
old format, but I manually edit them to the new one when applying the
patches for real.

> 2)  "Fix" isn't a good enough description.  :-)  Please give future readers
>     a few more words than that.

Ok:

	* config/os/solaris/solaris2.5/bits/ctype_base.h (ctype_base):
	Fix print to match vendor <ctype.h>.

should do.  Readers interested in even more details can consult the mailing
list archives :-)

	Rainer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]