This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Unify PPC section selection
- From: Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>
- To: Manfred Hollstein <manfred dot h at gmx dot net>
- Cc: gcc-patches at gcc dot gnu dot org,Geoff Keating <geoffk at geoffk dot org>
- Date: Sun, 19 May 2002 17:22:08 +0200
- Subject: Re: [PATCH] Unify PPC section selection
- References: <200205191709.01941@enzo.bigblue.local> <3CE7C124.4040004@gmx.net>
On Sunday 19 May 2002 17:13, Manfred Hollstein wrote:
> Franz Sirl wrote:
> [...]
>
> > +/* Calculate an index for the section arrays used in
> > rs6000_select_section + and rs6000_unique_section below. The coding is
> > like that:
> > + .rodata: 0
> > + .sdata2: 1
> > + .data: 2
> > + .sdata: 3
> > + .bss: 4
> > + .sbss: 5
> > + .text: 6. */
>
> [...]
>
> > + if (TREE_CODE (decl) == FUNCTION_DECL)
> > + sec = 6;
>
> Franz, I'd prefer to use some more self-explanatory names for the
> sections than pure numbers instead. #define's or enum's would make
> the code much more self-evident than with the plain numbers.
>
> Agreed?
Well, I have no problem with that, but I don't think it's worth it, it's used
nowhere else and the code that uses it has only a few lines.
Franz.