This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Trailing whitespace removal patch for manual
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: "Joseph S. Myers" <jsm28 at cam dot ac dot uk>
- Cc: Phil Edwards <phil at jaj dot com>, <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 29 Mar 2002 12:09:06 +0100
- Subject: Re: Trailing whitespace removal patch for manual
- References: <Pine.LNX.4.33.0202251221190.2928-100000@kern.srcf.societies.cam.ac.uk>
"Joseph S. Myers" <jsm28@cam.ac.uk> writes:
> On Sun, 24 Feb 2002, Phil Edwards wrote:
>
>> On Sat, Feb 23, 2002 at 02:38:38PM +0100, Florian Weimer wrote:
>> > Only if lack of whitespace it is enforced mechanically on commit (or
>> > during make). Otherwise, trailing whitespace will be introduced
>> > pretty soon again.
>
> That argument would apply just as well to any kind of bug or coding style
> violation. Putting enforcement on commit is likely to cause problems.
The problem seems to be that all pending patches have to reworked when
someone removes trailing whitespace. CVS merging is not very tolerant
in this regard.
> Why put this (a rule that modifies non-generated source files) in the
> Makefile? A script in contrib would be more appropriate.
Yes, you are right.
By the way, what about tab characters?