This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: 3.1: fix for PR 5948


On Mar 16, 2002, Jan Hubicka <jh@suse.cz> wrote:

>> This patch fixes PR 5948.  Rainer Orth, the reporter, verified it.
>> 
>> The problem was that gcc generates `.quad' directives on x86 Solaris
>> when using the Solaris assembler.  This assembler doesn't understand
>> .quad, and the bootstrap fails.
>> 
>> Ok for 3.1 branch and trunk?

> Oops, something got missed. The QUAD should not be used unless 64bit
> mode is enabled.

> I see my original patch for revamping the output to target structure
> didn't get in and has been replaced by superrior one, but this particual
> hunk got lost.  I will come with proper sollution tomorrow.

When you do so, will you please include in your patch a hunk to remove
the following chunk of code from gcc/config/sh/sh.h's OVERRIDE_OPTIONS:

  else									\
    {									\
       /* Only the sh64-elf assembler fully supports .quad properly.  */\
       targetm.asm_out.aligned_op.di = NULL;				\
       targetm.asm_out.unaligned_op.di = NULL;				\
    }									\

as well as the following comment from gcc/config/sh/sh.c:

/* These are NULLed out on non-SH5 in OVERRIDE_OPTIONS.  */


Consider them pre-approved.  Thanks!

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]