This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: sh64-elf (SH5) port


> structures with callbacks.  As clean as it may look, it makes it way
> more difficult to introduce a new entry point, and it makes it
> insanely for difficult to define a md-specific entry point in such a
> way that it depends on information only available at run time.

I don't really think the OVERRIDE_OPTIONS approach is that ugly.

I do agree that using a pointer, rather than a variable, would be cleaner. 
I'm not sure why we ended up doing it the way that we did.  But, changing
from one mode to the other is a pretty simple exercise, compared to the work
required to get the macros turned into functions.  And that work is a huge
win in lots of ways, the least of which is probably the increased 
functionality (dynamic configuration) that you point out.  The bigger wins
come from the fact that we reduce the likelihood of breaking other 
configurations, increase the self-documentation available, and so forth.

Thanks,

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]