This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFA] Second try a fixing cygwin/win9x mmap problem
On Mon, Jan 14, 2002 at 02:19:18PM -0500, Christopher Faylor wrote:
> >
> >Could you post the updated patch?
>
> Here you go. Added a comment, too.
Please make two more changes to the commentary. Move this comment
/* Use mmap if the file is big enough to be worth it (controlled
by MMAP_THRESHOLD) and if we can safely count on there being
at least one readable NUL byte after the end of the file's
contents. This is true for all tested operating systems when
the file size is not an exact multiple of the page size. */
from just above the use of SHOULD_MMAP, to just above where
SHOULD_MMAP is defined. Also, mention what Windows 9x does
that makes it impossible for Cygwin to give cpplib the mmap
semantics it wants (i.e. doesn't zero-fill trailing partial
pages).
Approved with those changes.
zw