This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Clarify rules for testing patches

On Wed, Dec 05, 2001 at 03:30:15PM +0100, Gerald Pfeifer wrote:
> On Tue, 4 Dec 2001, Zack Weinberg wrote:
> > Here it is.  There are still some typo fixes, I'll split them out if
> > the text changes need more revision.
> 
> Given the feedback, I believe it's better to split.

Okay.

I'm checking in the appended patch, which is purely structural and
copyeditorial fixes.  You approved more than that, but I think it's
better to leave those changes in with the other content changes.  I'll
revise that part of the patch and resubmit it shortly.

(The deltas that don't appear to do anything delete trailing
whitespace.)

zw

===================================================================
Index: contribute.html
--- contribute.html	2002/01/02 02:42:29	1.43
+++ contribute.html	2002/01/03 20:24:37
@@ -9,9 +9,9 @@
 <body>
 <h1 align="center">Contributing to GCC</h1>
 
-<p>We strongly encourage contributions of code, bugfixes, new
+<p>We strongly encourage contributions of code, bug fixes, new
 optimizations, new features, documentation updates, web page
-improvements, etc. for GCC</p>
+improvements, etc. for GCC.</p>
 
 <p>There are certain legal requirements and style issues which all
 contributions must meet.</p>
@@ -36,8 +36,8 @@ copyright assignment form filled out and
 documentation by the FSF</a> for details and contact us (either via
 the <a href="mailto:gcc@gcc.gnu.org";>gcc@gcc.gnu.org</a> list or the
 GCC maintainer that is taking care of your contributions) to obtain
-the relevant forms. Note that it's a good idea to put
-<a href="mailto:assignments@gnu.org";>assignments@gnu.org</a> in copy with
+the relevant forms.  It's a good idea to send
+<a href="mailto:assignments@gnu.org";>assignments@gnu.org</a> a copy of
 your request.</p>
 
 <p>Small changes can be accepted without a copyright assignment form
@@ -94,7 +94,7 @@ Documentation changes do not require a b
 
 <dt>The patch itself</dt>
 <dd>
-If you are accessing the <a href="cvs.html"> CVS repository</a> at
+If you are accessing the <a href="cvs.html">CVS repository</a> at
 gcc.gnu.org, use &quot;<code>cvs update; cvs diff -c3p</code>&quot;;
 else, use &quot;<code>diff -c3p OLD NEW</code>&quot; or
 &quot;<code>diff -up OLD NEW</code>&quot;.  If your version of diff
@@ -137,7 +137,7 @@ discouraged to post patches as MIME part
 and send it to <a
 href="mailto:gcc-patches@gcc.gnu.org";>gcc-patches@gcc.gnu.org</a>.
 All patches and related discussion should be sent to the gcc-patches
-mailinglist.  For further information on the GCC CVS repository, see
+mailing list.  For further information on the GCC CVS repository, see
 the <a href="cvs.html">Anonymous read-only CVS access</a> and <a
 href="cvswrite.html">Read-write CVS access</a> pages.</p>
 
===================================================================
Index: cvswrite.html
--- cvswrite.html	2001/11/28 23:35:19	1.44
+++ cvswrite.html	2002/01/03 20:24:37
@@ -16,11 +16,12 @@ our significant developers. Maintainers 
 the <a href="gnatswrite.html">GNATS database</a>.</p>
 
 <hr />
-<h3>Contents</h3>
+<h2>Contents</h2>
 <ol>
   <li><a href="#authenticated">Authenticated access</a></li>
   <li><a href="#setup">Setting up your local CVS tree</a></li>
   <li><a href="#policies">Write access policies</a></li>
+  <li><a href="#testing">Testing changes</a></li>
   <li><a href="#checkin">Checking in a change</a></li>
   <li><a href="#example">Example check-in session</a></li>
   <li><a href="#branches">Creating branches</a></li>
@@ -51,9 +52,11 @@ checking in your changes.</p>
 from your remote machine.  Set <code>CVS_RSH</code> in your
 environment to "<code>ssh</code>".  Then issue the command</p>
 
-<blockquote><code>
+<blockquote>
+<pre>
 cvs -z 9 -d :ext:<i>username</i>@gcc.gnu.org:/cvs/gcc co gcc
-</code></blockquote>
+</pre>
+</blockquote>
 
 <p>where <i>username</i> is your user name at
 <code>gcc.gnu.org</code>.  This will check out a new CVS tree that you
@@ -64,9 +67,11 @@ committing changes.</p>
 replacing all the "Root" files in the local tree with the following
 contents:</p>
 
-<blockquote><code>
+<blockquote>
+<pre>
 <i>username</i>@gcc.gnu.org:/cvs/gcc
-</code></blockquote>
+</pre>
+</blockquote>
 
 <p>To avoid the nuisance of having to supply your passphrase for each
 operation, you may want to use <code>ssh-agent</code>(1) followed by
@@ -87,7 +92,7 @@ ForwardX11 no
 
 <h2>Web pages</h2>
 
-<p>Note that when you check in changes to our web pages, these will
+<p>When you check in changes to our web pages, they will
 automatically be checked out into the web server's data area.</p>
 
 <hr />
@@ -149,7 +154,7 @@ copyright assignments on file.  Merging 
 mainline still needs approval in the usual way.</p>
 
 <hr />
-<h2><a name="checkin">Checking in a change</a></h2>
+<h2><a name="testing">Testing changes</a></h2>
 
 <p>It is expected that before you check in any change you will do the
 following:</p>
@@ -191,6 +196,9 @@ minimize the amount of time where the tr
 all. Repeated failure to adhere to these rules could result in the
 revocation of check-in privileges by the Steering Committee.</p>
 
+<hr />
+<h2><a name="checkin">Checking in a change</a></h2>
+
 <p>The following is meant to provide a very quick overview of how to
 check in a change.  It is not meant to be a replacement for the CVS
 manual but instead a supplement.  The CVS manual is distributed as
@@ -208,7 +216,7 @@ code.</p>
 <li>Sync your sources with the master repository via "<tt>cvs
 update</tt>" before attempting a checkin; this will save you a little
 time if someone else has modified that file since the last time you
-sync'd your sources.  It will also identify any files in your local
+synced your sources.  It will also identify any files in your local
 tree that you have modified.</li>
 
 <li>Apply the patch to your local tree and update the
@@ -289,7 +297,7 @@ sources.</p>
 
 <blockquote>
 <pre>
-[/law/gcc/gcc] patch &lt; ~/Mail/gcc/pendingpatches/42 
+[/law/gcc/gcc] patch &lt; ~/Mail/gcc/pendingpatches/42
 Hmm...  Looks like a new-style context diff to me...
 The text leading up to this was:
 <i>[ uninteresting text deleted ]</i>
@@ -410,7 +418,7 @@ Checking in genattrtab.c;
 /cvs/gcc/./gcc/genattrtab.c,v  &lt;--  genattrtab.c
 new revision: 1.15; previous revision: 1.14
 done
-[/law/gcc/gcc] 
+[/law/gcc/gcc]
 </pre>
 </blockquote>
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]