This is the mail archive of the
mailing list for the GCC project.
Re: Unreviewed patches (was Re: Freeze timing and questions)
- From: DJ Delorie <dj at redhat dot com>
- To: rth at redhat dot com
- Cc: ghazi at caip dot rutgers dot edu, gcc-patches at gcc dot gnu dot org, gcc at gcc dot gnu dot org
- Date: Thu, 20 Dec 2001 21:10:45 -0500
- Subject: Re: Unreviewed patches (was Re: Freeze timing and questions)
- References: <200112180554.AAA26669@caip.rutgers.edu> <20011220175526.B2156@redhat.com>
> > Patch to avoid messy output when running configure:
> > http://gcc.gnu.org/ml/gcc-patches/2001-12/msg01721.html
> This looks strange to me. I'd rather aoliva or someone
> review this instead.
It's syntactically correct. When you redirect output, the shell
redirects it for the subprocess. It doesn't always redirect its own
output, which is where the "file not found" message comes from
(depending on the shell). With the parens, the shell is redirecting
the output of another /bin/sh, and *that* /bin/sh is the one with the
So if you don't have a problem with the diagnostic messages going
away, go ahead and approve it. I don't see anything wrong with it.