This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH / RFA]: Load hoisting fix




--On Wednesday, December 19, 2001 11:08:08 AM -0500 David Edelsohn 
<dje@watson.ibm.com> wrote:

> 	With my last message I did not make it clear that I was submitting
> the patch for approval.  As mentioned yesterday, the patch has been
> bootstrapped on both powerpc-ibm-aix4.3.3.0 and i686-pc-linux-gnu with no
> new regressions.  This fixes the divconst-3.c regressions on AIX.

The patch is OK, but I would prefer that you create a macro REGNO_NREGS
that encapsulates the cacluation of the number of registers corresponding
to a register.  That way everyone else doesn't have to remember *how*
to do the calculation (even though they still have to remember that they
need to *do* it).

Patch pre-approved with that change.

Thanks,

-- 
Mark Mitchell                mark@codesourcery.com
CodeSourcery, LLC            http://www.codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]