This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Darwin FP constant peephole (again)



> > do these have to be conditionally compiled?  We're trying to cut down
> > on conditionally compiled code when possible.
> 
> The other one has to be because of machopic_function_base_name(), at
> least that's the easiest way to deal with it and consistent with all
> the other places where it's referenced.  This one doesn't have to, but
> they go together, so it seems cleaner to me to have this one conditional
> also.

iirc, config/darwin.c is outside of config/rs6000/ because it may be
used for non ppc targets.  from the comments in
machopic_function_base_name(), it seems like this is only a ppc thing. 
so maybe it makes sense to move it out of darwin.c and into rs6000.c,
thus allowing the above code to be unconditionalized.

not being nitpicky, just wishing we had less conditionally compiled
code. :)

-- 
Aldy Hernandez			E-mail: aldyh@redhat.com
Professional Gypsy
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]