This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

PATCH: gnatsweb.pl


GCC folks, I installed this so that our gnatsweb 2.9.3 installation works
both with and without style sheets supported/enabled.

GNATS folks (Yngve): Without this patch, gnatsweb mixes classic HTML color
tags and CSS with the result that (for example on Netscape 4.7) users with
style sheets disabled easily get white text on white background.

The first patch is for gnatsweb 2.9.3 and tested, the second for current
development sources 2.99.2 and untested. (If you agree, would you mind
applying the one against 2.9.3 for me? I can take care of 2.99.2.)

Gerald

2001-12-18  Gerald Pfeifer  <pfeifer@dbai.tuwien.ac.at>

        * gnatsweb.pl (page_start_html): Do not mix classic HTML color
        tags (BGCOLOR) and CSS.

Index: gnatsweb.pl
===================================================================
RCS file: /cvs/gcc/wwwdocs/cgi-bin/gnatsweb.pl,v
retrieving revision 1.45
retrieving revision 1.49
diff -u -3 -p -r1.45 -r1.49
--- gnatsweb.pl	2001/12/15 09:57:40	1.45
+++ gnatsweb.pl	2001/12/18 21:11:00	1.49
@@ -2501,7 +2501,7 @@ EOF
   $createurl = get_createpr_url(0,1);

   $row = qq(<TR>\n<TD><TABLE BORDER="0" CELLSPACING="0" CELLPADDING="3" WIDTH="100%">);
-  $row .= qq(<TR BGCOLOR="$site_banner_background">\n<TD ALIGN="LEFT">);
+  $row .= qq(<TR STYLE="background-color: $site_banner_background">\n<TD ALIGN="LEFT">);
   $row .= qq(<SPAN STYLE="$bannerstyle $banner_fontsize1">$global_prefs{'database'}&nbsp;&nbsp;</SPAN>)
         if $global_prefs{'database'};
   $row .= qq(<SPAN STYLE="$bannerstyle $banner_fontsize2">User: $db_prefs{'user'}&nbsp;&nbsp;</SPAN>)

Index: gnatsweb.pl
===================================================================
RCS file: /cvsroot/gnatsweb/gnatsweb/gnatsweb.pl,v
retrieving revision 1.87
diff -u -3 -p -r1.87 gnatsweb.pl
--- gnatsweb.pl	12 Dec 2001 14:10:56 -0000	1.87
+++ gnatsweb.pl	18 Dec 2001 21:20:30 -0000
@@ -3077,7 +3077,7 @@ EOF
   my $createurl = get_pr_url('create', 0, 1);

   $row = qq(<tr>\n<td><table border="0" cellspacing="0" cellpadding="3" width="100%">);
-  $row .= qq(<tr bgcolor="$site_banner_background">\n<td align="left">);
+  $row .= qq(<tr style="background-color: $site_banner_background">\n<td align="left">);
   $row .= qq(<span style="$bannerstyle $banner_fontsize1">$global_prefs{'database'}&nbsp;&nbsp;</span>)
                  if $global_prefs{'database'};
   $row .= qq(<span style="$bannerstyle $banner_fontsize2">User: $db_prefs{'user'}&nbsp;&nbsp;</span>)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]