This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ABI union alignment fix for place_union_field




--On Saturday, December 08, 2001 01:26:03 AM -0500 David Edelsohn 
<dje@watson.ibm.com> wrote:

> 	When stor-layout.c:layout_record() was split into place_field()
> and place_union_field(), the ADJUST_FIELD_ALIGN was only kept in one
> instance when it should be applied to both records and unions.  Without
> restoring this fix, GCC is not compatible with the AIX ABI and is not
> backward compatible with gcc-2.95.
>
> 	I would like to apply this to both the trunk and the gcc-3.0
> branch.

OK.

Please also add a regression test case that tests for this problem
so that it does not arise again.  This will likely be an AIX-specific
or PowerPC-specific test in which case it should be run only on
those systems.  It is OK to check in the fix on the branch without
the test case, but we should have both on the mainline as soon as
possible.

Thank you,

-- 
Mark Mitchell                mark@codesourcery.com
CodeSourcery, LLC            http://www.codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]