This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: configure.in patch to support building newlib natively on x86 Linux



> !    case "$host" in
> !    i[3456]86-pc-linux*)

Why are you checking host here, instead of target?  It shouldn't
matter, but it looks funny to be checking $host to set target flags.

Also, you can avoid replicating the default case if you do this
instead:

    case "${target}-${is_cross_compiler}" in
    i[3456]86-pc-linux*-no)

> !        FLAGS_FOR_TARGET=`echo $FLAGS_FOR_TARGET | sed -e 's/-nostdinc/ /'`

That won't work if $FLAGS_FOR_TARGET starts with '-', which is likely.
Echo will think it's an option for echo itself.  You also don't take
into account flags like -nostdinc++.  How about this?

      FLAGS_FOR_TARGET=`echo " $FLAGS_FOR_TARGET " | sed -e 's/ -nostdinc / /'`


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]