This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] remove arm/unknown-elf.h


> Every consumer of arm/unknown-elf.h immediately includes arm/elf.h (via
> tm_files).  There are no consumers of arm/unknown-elf.h only.
> Thus arm/unknown-elf.h can be folded into arm/elf.h.

You can't reach this conclusion from your argument; it should be perfectly 
possible to create an ELF target that uses elf.h, but doesn't want the 
definitions in unknown-elf.h -- that is the guiding decision.

unknown-elf.h is supposed to contain the bits of an elf interface that 
would normally be set by the OS: in this case there is no OS (it's 
unknown).  It seems bizarre to me that the arm-linux ports are including 
this file.

So I don't think your patch is correct.

It seems to me that the abstractions in GCC for target CPU and OS are 
horribly intermixed, and that it would be useful to try and tease these 
apart somehow.  Multi-architecture OSs such as Linux and *BSD are 
revealing problems in this area that probably need some thought.

R.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]