This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: vector_size attribute


On 4 Dec 2001, Aldy Hernandez wrote:

> as per, the altivec discussion, here is a patch to add a vector_size
> attribute-- complete with documentation and a test case.  and waddaya
> know, it actually works...

You're not testing all the invalid uses you're diagnosing.

Are you sure this should be a decl attribute?  What about declaring
pointers to vectors?  You may want to set all the flags decl_required,
..., to false then navigate the tree node to find the underlying type such
as "int" to which the attribute applies.

You failed to update the overall list of variable attributes above the
table describing each one.

> + causes the compiler to set the mode for @code{foo}, to be 16 bytes,
> + divided into @code{int} sized units.  Assuming a 32 bit int (a vector of

"32-bit".

> + 4 units of 4 bytes), the corresponding mode of @code{foo} will be V4SI.

"V4SI@.".

-- 
Joseph S. Myers
jsm28@cam.ac.uk


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]