This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: Further C / ObjC initialization cleanup
- From: Richard Henderson <rth at redhat dot com>
- To: Neil Booth <neil at daikokuya dot demon dot co dot uk>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 27 Nov 2001 14:16:49 -0800
- Subject: Re: RFA: Further C / ObjC initialization cleanup
- References: <20011127210916.A26489@daikokuya.demon.co.uk>
On Tue, Nov 27, 2001 at 09:09:16PM +0000, Neil Booth wrote:
> Buried in the changes is
>
> diagnostic_format_decoder (global_dc) = &c_tree_printer;
> lang_missing_noreturn_ok_p = &c_missing_noreturn_ok_p;
>
> which I've moved from c-lang.c initialization code to c-objc-common.c,
> despite ObjC not having anything similar.
I'm not sure they'll be exactly right either, but they shouldn't be
that far off. We'll let an objc maintainer take care of this. ;-)
> * Makefile.in: Update, and add c-objc-common.o dependencies.
> * c-lang.c: Remove unnecessary includes.
> (c_init): Move bulk of code to c_objc_common_init, and call it.
> (c_tree_printer, c_missing_noreturn_ok_p, c_disregard_inline_limits,
> inline_forbidden_p, c_cannot_inline_tree_fn): Move to
> c-objc-common.c.
> * c-objc-common.c: New. Mostly pulled from c-lang.c.
> * c-tree.h (c_disregard_inline_limits, c_cannot_inline_fn,
> c_objc_common_init, c_missing_noreturn_ok_p): New.
> * toplev.c: Update comment.
> * objc/ojbc-act.c (LANG_HOOKS_TREE_INLINING_CANNOT_INLINE_TREE_FN,
> LANG_HOOKS_TREE_INLINING_DISREGARD_INLINE_LIMITS,
> LANG_HOOKS_TREE_INLINING_ANON_AGGR_TYPE_P): Override.
> (objc_init): Update to use c_objc_common_init.
Ok.
> +/* ### When changing hooks, consider if OjbC needs changing too!! ### */
> +/* ### When changing hooks, consider if OjbC needs changing too!! ### */
Typo.
r~