This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [v3] limits cleanups: move to cpu_limits.h, os/cpu sep, removal


Benjamin Kosnik wrote:

>Moves config/cpu/*/bits/limits.h to cpu_limits.h as discussed previously.
>Removes older numeric_limits files.
>Pushes out cpu-specific defines from os_defines.h

This looks incorrect for s390:  you define __glibcpp_long_bits to 64
for both s390-* and s390x-* targets.  However, this is only correct
for s390x-*, for s390-* it should be 32.

We could either keep the #ifdef or make a new s390x/ subdirectory;
I didn't do that originally only because the atomicity.h file can
be used on both s390 and s390x without changes, so there was no
necessity ...


Mit freundlichen Gruessen / Best Regards

Ulrich Weigand

--
  Dr. Ulrich Weigand
  Linux for S/390 Design & Development
  IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032 Boeblingen
  Phone: +49-7031/16-3727   ---   Email: Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]