This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: non-GNU make broken again during `make bootstrap'
- To: gcc-patches at gcc dot gnu dot org
- Subject: Re: PATCH: non-GNU make broken again during `make bootstrap'
- From: Loren James Rittle <rittle at latour dot rsch dot comm dot mot dot com>
- Date: Thu, 4 Oct 2001 17:12:42 -0500 (CDT)
- CC: mark at codesourcery dot com, David dot Billinghurst at riotinto dot com, ghazi at caip dot rutgers dot edu, robertlipe at usa dot net, toa at pop dot agri dot ch, shebs at apple dot com, dalej at apple dot com, bkorb at pacbell dot net
- References: <200109280425.f8S4PHd29846@latour.rsch.comm.mot.com> <200110040225.f942PMu06895@latour.rsch.comm.mot.com>
- Reply-to: rittle at labs dot mot dot com
>> Consider a patch that passes these variables down to fixinc (without
>> the HOST_ prefix, of course :-) pre-approved for mainline, and
>> strongly recommended for the 3.0 branch, subject to Mark's approval.
> This patch moves us forward (tested by me and Robert L.):
[...]
I have attempted to CC everyone that reported a problem over the last
few days. I am really sorry. Especially after Gerald gave me a
special notice of the effort I put into testing it. ;-/
Regarding the issues uncovered on OS X, I have no clue.
Regarding alloca issue, propagating HOST_LIBS as well might have fixed
it but this general approach does not appear robust.
I am afraid to report that the complexity of the Makefiles is too
great for me to be able to handle in order to fix a problem that only
affects non-GNU make users. That said, Bruce and I had the same idea
and I will spend the few minutes to produce that safer patch and see
if it works.
Thus, this patch moves us back to before I started causing so much
pain to a few people:
[Patch for branch only removes propagation of HOST_CC.]
2001-10-04 Loren J. Rittle <ljrittle@acm.org>
* Makefile.in (STAGE2_FLAGS_TO_PASS): Remove patches which
propagated HOST_CC, HOST_CFLAGS, HOST_LDFLAGS and HOST_CPPFLAGS.
Index: Makefile.in
===================================================================
RCS file: /cvs/gcc/egcs/gcc/Makefile.in,v
retrieving revision 1.743
diff -c -r1.743 Makefile.in
*** Makefile.in 2001/10/04 02:20:29 1.743
--- Makefile.in 2001/10/04 21:58:32
***************
*** 2958,2967 ****
# WARN_CFLAGS setting can't be to the expansion of GCC_WARN_CFLAGS in
# the context of the stage_x rule.
STAGE2_FLAGS_TO_PASS = \
- HOST_CC="$(HOST_CC)" \
- HOST_CFLAGS="$(HOST_CFLAGS)" \
- HOST_LDFLAGS="$(HOST_LDFLAGS)" \
- HOST_CPPFLAGS="$(HOST_CPPFLAGS)" \
CFLAGS="$(BOOT_CFLAGS)" \
LDFLAGS="$(BOOT_LDFLAGS)" \
WARN_CFLAGS="\$$(GCC_WARN_CFLAGS)" \
--- 2958,2963 ----
Applied to mainline. Reopened PR 4422. Permission to fix branch as
well?
Regards,
Loren