Re: [patch] Prevent ICE in flow_loop_dump

[Diego Novillo <dnovillo at redhat dot com>]

On Mon, 27 Aug 2001, Daniel Berlin wrote:

> Diego Novillo <dnovillo@redhat.com> writes:
> 
> > flow_loop_dump assumes that loop->first->head and loop->last->end
> > are set.  This is not true in the case of tree flowgraphs.
> >
> 
> I could have sworn I had submitted a patch for the exact same
> problem.
> Oh wait, no, that was only in the patch I had sent to you a while
> ago. 
> 
> > OK to commit to trunk?
> 
> Err, isn't this considered an obvious fix?
> 
The semantics of the obvious rule are not very clear to me.  My
understanding is that they only cover misspellings/typos in
comments and documentation.  The only reference I could find in
the web pages is

http://www.gnu.org/software/gcc/cvswrite.html#policies

"Also note that fixes for obvious typos in ChangeLog files, docs,
web pages, comments and similar stuff need not be approved. Just
check in the fix. We don't want to get overly anal about checkin
policies."

There was some discussion about this topic recently, but I can't
find the thread at the moment.

With regard to this patch, it may not be the best solution.
Maybe we should have different dump functions for tree loops and
rtl loops (as we do on basic blocks).

Or maybe the consensus is to keep adding smarts to the existing
dump functions so that they can handle different ILs.  This may
not be the best long-term solution.

Diego.