This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [patches] Re: spec20000 eon fix


> On Fri, Aug 03, 2001 at 11:26:24PM +0200, Jan Hubicka wrote:
> > 	(fixup_abnormal_calls): New function.
> 
> The name is no longer appropriate.  You might want to put this
OK, I was wondered about that, but I was unable to
find better one.
Perhaps "fixup_abnormal_edges"?
> function in reload1.c somewhere instead of flow.c, since that's
> where it's used (and I wouldn't expect it to be used elsewhere).
> 
> > + 	  while (insn && GET_CODE (insn) == INSN)
> > + 	    {
> > + 	      next = NEXT_INSN (insn);
> > + 	      insert_insn_on_edge (PATTERN (insn), e);
> > + 	      flow_delete_insn (insn);
> > + 	      insn = next;
> > + 	    }
> 
> Why not use split_block and move all abnormal edges?
I would need then to also update the frequencies and counts manually.
Inserting on the edges looked more clear to me.

Also I usually suceed in not creating tohe basic block(as
the insns just get output to the begginig of
next one).

Would you preffer the split_block?
Honza
> 
> 
> r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]