This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix profile.c CFG updating
- To: Jan Hubicka <jh at suse dot cz>
- Subject: Re: Fix profile.c CFG updating
- From: Richard Henderson <rth at redhat dot com>
- Date: Fri, 27 Jul 2001 18:03:01 -0700
- Cc: gcc-patches at gcc dot gnu dot org, patches at x86-64 dot org
- References: <20010727155724.G19763@atrey.karlin.mff.cuni.cz>
On Fri, Jul 27, 2001 at 03:57:24PM +0200, Jan Hubicka wrote:
> ! for (e = bb->succ; e->flags & (EDGE_FAKE | EDGE_FALLTHRU); e = e->succ_next);
Please use "continue;" on the next line to document that this is
supposed to be an empty loop body. Line wrap.
> ! error ("Arc profiling: some edge counts were bad.");
Downcase error strings. What's the point of this one anyway?
It's telling us that we got error messages. Well, we knew that
since we saw them.
> ! error (".da file contents exhausted too early\n");
No newline in error strings.
You've forgotten to mention that you tested these patches on ...
r~