Re: egcs/gcc ChangeLog config.gcc config/chorus.h ...

[Chandra Chavva <cchavva at cygnus dot com>]

On Wed, 18 Jul 2001, Joseph S. Myers wrote:

> On 17 Jul 2001 cchavva@gcc.gnu.org wrote:
> 
> > CVSROOT:	/cvs/gcc
> > Module name:	egcs
> > Changes by:	cchavva@gcc.gnu.org	2001-07-17 14:53:12
> > 
> > Modified files:
> > 	gcc            : ChangeLog config.gcc 
> > Added files:
> > 	gcc/config     : chorus.h 
> > Removed files:
> > 	gcc/config/sparc: chorus.h 
> > 
> > Log message:
> > 	* config.gcc: For *-*-chorusos triplet, get chorus.h file from
> > 	config directory.
> > 	* config/i386/chorus.h: Move up.
> > 	* config/sparc/chorus.h: Likewise.
> > 	* config/rs6000/chorus.h: Likewise.
> > 	* config/chorus.h: Moved here.
> > 
> > Patches:
> > http://gcc.gnu.org/cgi-bin/cvsweb.cgi/egcs/gcc/ChangeLog.diff?cvsroot=gcc&r1=1.10691&r2=1.10692
> 
> Your changes to gcc/ChangeLog (diffs between revisions 1.10691 and
> 1.10692) here are 14000 lines; apparently you have duplicated a large
> amount of the ChangeLog and the previous rotated one.  Can you please fix
> this?
> 

  I fixed this. I am really sorry. 

Chandra

> Note that cvswrite.html says
> 
>     4. We recommend using "cvs diff" after applying a patch to a local 
>        tree. Review the output to make sure that only the changes you 
>        wanted to check in will be checked in. Also check to see if the  
>        copyright dates need to be updated.
> 
> Please always do this; even if the genuine changes are several thousand
> lines, you always should read them again just before commit to make sure
> that you are committing exactly what you intended.
> 
> Was this patch approved in private mail?  I can't find any sign of
> discussion of it since it was posted in April, and I think it makes it a
> lot clearer what's going on if approvals are made to the public lists, and
> if, when a patch is committed months after the last discussion, this
> commit is mentioned on gcc-patches.
>