This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Trivial toplev.c patch
- To: Richard Kenner <kenner at vlsi1 dot ultra dot nyu dot edu>
- Subject: Re: Trivial toplev.c patch
- From: Mark Mitchell <mark at codesourcery dot com>
- Date: Thu, 12 Jul 2001 19:36:12 -0700
- cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "sje at cup dot hp dot com" <sje at cup dot hp dot com>
--On Thursday, July 12, 2001 08:50:39 PM +0000 Richard Kenner
<kenner@vlsi1.ultra.nyu.edu> wrote:
> But it's not how we want to do things. The right thing is to define
> ASM_FILE_START in defaults.h so that we avoid #ifdef's in the main
> code.
>
> Please back and out and make that change instead.
>
> Well, what about all the other ones like ASM_FILE that are done the same
> way?
>
> I think consistency is important and this was making the code more
> consistent.
But, we've already decided to consistency redo this stuff using
defaults.h. So, we're making a conscious break with tradition, and
gradually moving in the new direction. Consistency is still the goal
-- but in a new style. To help out, please feel free to convert all
of the similar usages!
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com