This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Localization fixes
- To: Paolo Bonzini <bonzini at gnu dot org>
- Subject: Re: [PATCH] Localization fixes
- From: "Zack Weinberg" <zackw at stanford dot edu>
- Date: Thu, 21 Jun 2001 10:21:42 -0700
- Cc: gcc-patches at gcc dot gnu dot org
On Thu, Jun 21, 2001 at 12:41:59PM +0200, Paolo Bonzini wrote:
> This patch relative to 3.0 fixes a few localization
> problems, mostly regarding:
> - unlocalized format arguments
> - differentiating equal strings with different translations
> (e.g. one translation would require an article, the
> other won't)
> - unlocalized format strings for ERROR (I used N_ for
> those)
> - giving opportunities for better localization.
We'd prefer this sort of patch be generated versus the mainline. The
3.0 branch is currently frozen, and will probably only accept critical
bug fixes once it unfreezes.
I have one comment on the structure of the patch: ...
> * gcc/c-lex.c: localize all arguments to ERROR
This is not supposed to be necessary; ERROR is defined as
#define ERROR(msgid) do { error(msgid); goto syntax_error; } while(0)
therefore exgettext is supposed to pick up all these strings (the key
is the argument named 'msgid'). Please look into why it isn't,
instead of inserting N_() all over the place.
> * gcc/c-typeck.c: localization fixes
A tiny bit more explanation please, along the lines of your summary at
the top of your message.
--
zw I *will* wrestle it into shape eventually. I *will* clean it out,
*without* resorting to the redirection of a major navigable river.
-- Ray Radlein on lumber rooms