This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: your patch
- To: John David Anglin <dave at hiauly1 dot hia dot nrc dot ca>, Benjamin Kosnik <bkoz at redhat dot com>
- Subject: Re: your patch
- From: Mark Mitchell <mark at codesourcery dot com>
- Date: Wed, 13 Jun 2001 13:58:53 -0700
- cc: "dave dot anglin at nrc dot ca" <dave dot anglin at nrc dot ca>, "rittle at labs dot mot dot com" <rittle at labs dot mot dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
--On Wednesday, June 13, 2001 04:30:31 PM -0400 John David Anglin
<dave@hiauly1.hia.nrc.ca> wrote:
> Here it is! We need this to properly intialize the _STL_mutex_lock struct
> used in v3 on systems which define __GTHREAD_MUTEX_INIT_FUNCTION.
Threads are hairy. Cross-platform threads more so. Unfortunately,
I do not understand this code very well. It looks sane enough to me,
but we need more eyes.
We definitely need a review from at least one of, and probably
both of, Loren and Benjamin. Please look at this very, very carefully
to convince yourselves that this code is an improvement over what is
currently there. Try to think about race conditions, etc. If this
is only to fix HPUX 10, think about whether or not this patch
is likely to screw up on other more common platforms.
Loren, Benjamin, please let me know what you think ASAP.
Thank you,
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com