This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [v3] testsuite_flags absolute path fix


Benjamin Kosnik writes:

> I think we all agree on this, but so far there's not been a patch that 
> meets everybody's requirements.

And this will become a terribly big patch, since this construct is used in
so many places.  Perhaps we can find an easier way to apply this throughout
without duplicating in all affected places?

> This works for me: is this what you intended? 

Exactly.

> --- 1580,1591 ----
>   glibcpp_toolexeclibdir=no
>   
>   # Export build and source directories.
> ! # These need to be absolute paths, yet at the same time need to
> ! # canonicalize only relative paths, because then amd will not unmount
> ! # drives. Thus the use of PWDCMD: set it to 'pawd' or 'amq -w' if using 
> amd.
>   glibcpp_builddir=`pwd`

glibcpp_builddir is many processes' working directory, so there should be
no risk of amd unmounting it under their feet.

> ! glibcpp_srcdir=`case ${srcdir} in /*) echo ${srcdir} ;; *) echo \`cd 
> ${srcdir}; ${PWDCMD:-pwd}\` ;; esac`

This is the critical one.  Did you intend the linebreak (for cosmetic or
other reasons), or is this just an artifact (mail or otherwise)?

> ! glibcpp_prefixdir=${prefix}

Shouldn't need canonicalization and may not exist before installation.

	Rainer

-----------------------------------------------------------------------------
Rainer Orth, Faculty of Technology, Bielefeld University

Email: ro@TechFak.Uni-Bielefeld.DE


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]