This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: system include directories


On Wed, May 09, 2001 at 10:29:35AM +0100, Joseph S. Myers wrote:
> On Wed, 9 May 2001, Nathan Sidwell wrote:
> 
> > +               const char *non = other->sysp ? "" : "non-";
> 
> > +                              _("  as it is aliased to %ssystem directory \"%s\""),
> 
> This "%ssystem" usage won't work properly with i18n.  As a minimum you 
> would need to use _ around the "non-" string, but better to use two 
> separate strings with "system" and "non-system".

Also, you need to give the translators complete sentences.
s/as/because/ should do.  And it's not necessary to put _() around
strings passed to cpp_warning.

Other than that the cpp patch looks reasonable.  I'm not qualified to
review the others.

-- 
zw    If punishments don't compensate the victims and don't prevent future
      crimes they seem to me to be indistinguishable from random acts of
      sadism.
      	-- Bernard Peek


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]