This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] style fix for aix51.h and rs6000/mach.h
On Thu, May 03, 2001 at 11:34:18AM +0200, Franz Sirl wrote:
> > rs6000-ibm-aix[56789].* | powerpc-ibm-aix[56789].*)
> > xm_defines=POSIX
> >- tm_file="${tm_file} rs6000/aix.h rs6000/aix51.h"
> >+ tm_file="${tm_file} rs6000/aix.h rs6000/rs6000.h rs6000/aix.h
> >rs6000/aix51.h"
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> This is duplication, why? At this point tm_file should be set to
> rs6000/rs6000.h, so I don't see what you are heading at, it was already fine.
Because if you look at the diff, you'll see that I only unwound aix51.h
and rs6000/mach.h. I am not an expert on the AIX platform, nor do I have
an AIX box to test on. A simple cross compile showed my change did not
change anything. I did notice that rs6000/rs6000.h is being included
twice, but considering the config include spaghetti, how do I know 100%
that this wasn't intentional and that the dual include with rs6000/aix.h
in the middle isn't required?
If you are better setup to test this than I am, you are certainly free to
submit a set of follow up diffs.
--
-- David (obrien@FreeBSD.org)