This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Java: fix to java/1213
- To: tromey at redhat dot com
- Subject: Re: [PATCH] Java: fix to java/1213
- From: Alexandre Petit-Bianco <apbianco at cygnus dot com>
- Date: Fri, 23 Mar 2001 10:44:18 -0800 (PST)
- Cc: apbianco at cygnus dot com, gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
- References: <200103230204.SAA28440@deliverance.cygnus.com><87r8zpcc3t.fsf@creche.redhat.com>
- Reply-To: apbianco at cygnus dot com
Tom Tromey writes:
> Alex> +issue an error if it isnt' found.
>
> Typo: should be "isn't".
Thanks.
> Alex> + /* Implement -fwarn-wrong-classeszip */
>
> This comment is wrong.
Fixed.
> Since this is the sort of error which in the past has afflicted
> users who don't already know a lot about gcj, I would like to see a
> relatively verbose error message here.
OK. I agree too. I changed it to be this error message.
> (I know g77 has a convention for printing info page reference
> information in error messages. This seems like a cool idea to me,
> since it means that some IDE-ish program could easily go from the
> error message to the help text. If we want an info reference I
> guess it would make sense to look up their convention and use it.)
I'm guessing this is, for instance, the `[info -f g77 M LEX]' that I
can see in quoted strings. I guess I'll file a PR.
./A