This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: xm-*.h cleanup, continued
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Subject: Re: xm-*.h cleanup, continued
- From: "Zack Weinberg" <zackw at Stanford dot EDU>
- Date: Mon, 5 Mar 2001 12:58:39 -0800
- Cc: gcc-patches at gcc dot gnu dot org
- References: <200103051827.NAA16693@caip.rutgers.edu>
On Mon, Mar 05, 2001 at 01:27:46PM -0500, Kaveh R. Ghazi wrote:
> > From: "Zack Weinberg" <zackw@Stanford.EDU>
> >
> > On Sat, Mar 03, 2001 at 12:03:12AM -0500, Kaveh R. Ghazi wrote:
> > > > * crtstuff.c: Include tconfig.h, not auto-host.h and tm.h.
> > >
> > > Gross as it sounds, I think crtstuff really needed auto-host.h to get
> > > the definition of HAVE_GAS_HIDDEN. Apparently this was setup to work
> > > correctly even though its host vs target.
> >
> > Aaargh. What does HAVE_GAS_HIDDEN do and why didn't something break?
>
> It guards `asm (".hidden\t__dso_handle");' in crtstuff.c. I guess
> you'd only care if you're playing with DSOs.
feh... I have no idea what that might do.
> > And would you mind fixing it? I have too many hacks in my tree
> > right now.
> > zw
>
> Fixing it probably only requires doing the following. My linux box's
> gas doesn't support .hidden and I don't know of any testcases anyway.
> So I can't test it or claim it works. But its the same action taken
> before your patch, so... OK to install as an "obvious" fix to your
> last patch?
Seems reasonable, yes.
zw