This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: gcc/config/mips/mips.c Broken
- To: oldham at codesourcery dot com
- Subject: Re: gcc/config/mips/mips.c Broken
- From: kenner at vlsi1 dot ultra dot nyu dot edu (Richard Kenner)
- Date: Mon, 5 Feb 01 11:37:05 EST
- Cc: gcc-patches at gcc dot gnu dot org
Compiling gcc/config/mips/mips.c was broken by your 04Feb patch on
mips-sgi-irix6.5. Below are listings of compiler errors and warnings
and also listings of compiler warnings when it was compiling
correctly.
/users/joldham/pooma/dev/gcc/gcc/config/mips/mips.c:4958: `MASK_FLAG64' undeclared (first use in this function)
That was a typo: it should have been MASK_FLOAT64.
/users/joldham/pooma/dev/gcc/gcc/config/mips/mips.c:5828: warning: implicit declaration of function `pfatal_with_name'
Oops: I didn't think anything in config would call them:
Mon Feb 5 11:23:16 2001 Richard Kenner <kenner@vlsi1.ultra.nyu.edu>
* config/mips/mips.c (mips_make_temp_file): Call fatal_io_error,
not pfatal_with_name.
(mips_asm_file_end): Likewise; also pass more args to fatal_io_error.
*** config/mips/mips.c 2001/02/05 16:23:41 1.106
--- config/mips/mips.c 2001/02/05 16:29:54
*************** mips_make_temp_file ()
*** 5826,5830 ****
stream = fopen (temp_filename, "w+");
if (!stream)
! pfatal_with_name (temp_filename);
#ifndef __MSDOS__
--- 5826,5830 ----
stream = fopen (temp_filename, "w+");
if (!stream)
! fatal_io_error ("can't open %s", temp_filename);
#ifndef __MSDOS__
*************** mips_asm_file_end (file)
*** 6076,6090 ****
rewind (asm_out_text_file);
if (ferror (asm_out_text_file))
! fatal_io_error (temp_filename);
while ((len = fread (buffer, 1, sizeof (buffer), asm_out_text_file)) > 0)
if ((int) fwrite (buffer, 1, len, file) != len)
! pfatal_with_name (asm_file_name);
if (len < 0)
! pfatal_with_name (temp_filename);
if (fclose (asm_out_text_file) != 0)
! pfatal_with_name (temp_filename);
#ifdef __MSDOS__
--- 6076,6090 ----
rewind (asm_out_text_file);
if (ferror (asm_out_text_file))
! fatal_io_error ("can't rewind %s", temp_filename);
while ((len = fread (buffer, 1, sizeof (buffer), asm_out_text_file)) > 0)
if ((int) fwrite (buffer, 1, len, file) != len)
! fatal_io_error ("can't write to %s", asm_file_name);
if (len < 0)
! fatal_io_error ("can't read from %s", temp_filename);
if (fclose (asm_out_text_file) != 0)
! fatal_io_error ("can't close %s", temp_filename);
#ifdef __MSDOS__