This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: pa.c clean-up
- To: Alan Modra <alan at linuxcare dot com dot au>
- Subject: Re: pa.c clean-up
- From: Jeffrey A Law <law at redhat dot com>
- Date: Wed, 31 Jan 2001 18:15:42 -0700
- cc: gcc-patches at gcc dot gnu dot org
- Reply-To: law at redhat dot com
In message <Pine.LNX.4.21.0101242053430.29059-100000@front.linuxcare.com.au>y
ou write:
> Besides some tidying of code, this patch fixes a couple of bugs
This should be split into multiple patches.
> - VAL_14_BITS_P was called with negative of actual value used in
> instructions. With exactly the right value of frame size (8k), this
> could result in illegal instructions.
Sounds legitimate.
>
> - Lack of a blockage after the stack pointer was adjusted in
> hppa_expand_prologue resulted in register spills being scheduled before
> the stack frame was valid. We hit this problem in the linux kernel.
That would indicate a problem elsewhere since there should have been
a dependency between the insn which adjusts the stack pointer and any
stores in the prologue which use the stack pointer in their address.
The stuff for compiler warnings and formatting fixes should be a separate
patch.
jeff