This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Re: COME ON! FIXIT! AGAIN: cvs bootstrap failure on hppa2.0w-hp-hpux11.00
- To: Alan Modra <alan at linuxcare dot com dot au>
- Subject: Re: [PATCH] Re: COME ON! FIXIT! AGAIN: cvs bootstrap failure on hppa2.0w-hp-hpux11.00
- From: Jeffrey A Law <law at redhat dot com>
- Date: Wed, 31 Jan 2001 18:13:24 -0700
- cc: Markus Werle <markus at lufmech dot rwth-aachen dot de>, gcc-patches at gcc dot gnu dot org
- Reply-To: law at redhat dot com
In message <Pine.LNX.4.21.0101241641200.29059-100000@front.linuxcare.com.au>y
ou write:
> Here's another go at fixing the function name transformations that hppa
> uses to flag labels for functions.
Thanks. SOrry it's taking so long to look at this stuff in any detail.
> This time, we change `*foo' into `@foo',
Ahhh. In my quick read of this a few days ago I had this backwards
(thus my comment about indirect function call problems).
> in assemble_name. Losing the `*' is OK for hppa (I think) because the
> hppa ASM_OUTPUT_LABELREF is fairly innocuous. Please educate me if there
> are other places in the compiler that need to preserve the `*'; I have an
> alternate patch that defines ASM_OUTPUT_STAR_LABELREF.
Agreed.
> Interestingly, STRIP_NAME_ENCODING would never have worked for names
> starting with `*' due to lack of parentheses.
Certainly possible -- asm features certainly haven't been seriously
exercised in the PA port.
> gcc/ChangeLog
> * config/pa/pa.c (hppa_encode_label): Correct size of alloca
> buffer so we don't overrun it. Correct leading `*' case.
> * config/pa/pa.h (STRIP_NAME_ENCODING): Simplify now that we don't
> need to handle `*@'.
> (FUNCTION_NAME_P): Likewise.
Thanks. Applied.
jeff