This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[patch] to libstdc++-v3: fix for the Bourne shell
- To: gcc-patches at gcc dot gnu dot org, libstdc++-v3 at gcc dot gnu dot org
- Subject: [patch] to libstdc++-v3: fix for the Bourne shell
- From: msokolov at ivan dot Harhan dot ORG (Michael Sokolov)
- Date: Thu, 25 Jan 01 21:54:30 PST
Hi there,
There is a Bourne shell portability bug in libstdc++-v3's configure
(acinclude.m4 actually). The GLIBCPP_CHECK_GNU_MAKE macro uses ${MAKE:-make}.
This is not supported by the Bourne shell and prevents libstdc++-v3 from
building on UNIX. The patch below changes it to the standard Bourne shell
${MAKE-make}.
--
Michael Sokolov
Public Service Agent
International Engineering and Science Task Force
1351 VINE AVE APT 27 Phone: +1-714-738-5409
FULLERTON CA 92833-4291 USA (home office)
E-mail: msokolov@ivan.Harhan.ORG (ARPA TCP/SMTP)
2001-01-25 Michael Sokolov <msokolov@ivan.Harhan.ORG>
* acinclude.m4 (GLIBCPP_CHECK_GNU_MAKE): Bourne shell portability bug
(use ${MAKE-make}, not ${MAKE:-make}).
* aclocal.m4, configure: Regenerate.
Index: acinclude.m4
===================================================================
RCS file: /cvs/gcc/egcs/libstdc++-v3/acinclude.m4,v
retrieving revision 1.122
diff -p -r1.122 acinclude.m4
*** acinclude.m4 2001/01/23 20:58:20 1.122
--- acinclude.m4 2001/01/26 05:34:59
*************** dnl #### GLIBCPP_ to the macro name; add
*** 1555,1565 ****
dnl #### conditional's subshell (" --version" is not a command), using a
dnl #### different option to grep(1).
dnl #### -pme
AC_DEFUN(
GLIBCPP_CHECK_GNU_MAKE, [AC_CACHE_CHECK( for GNU make,_cv_gnu_make_command,
_cv_gnu_make_command='' ;
dnl Search all the common names for GNU make
! for a in "${MAKE:-make}" make gmake gnumake ; do
if ( $a --version 2> /dev/null | grep -c GNU > /dev/null )
then
_cv_gnu_make_command=$a ;
--- 1555,1568 ----
dnl #### conditional's subshell (" --version" is not a command), using a
dnl #### different option to grep(1).
dnl #### -pme
+ dnl #### Fixed Bourne shell portability bug (use ${MAKE-make}, not
+ dnl #### ${MAKE:-make}).
+ dnl #### -msokolov
AC_DEFUN(
GLIBCPP_CHECK_GNU_MAKE, [AC_CACHE_CHECK( for GNU make,_cv_gnu_make_command,
_cv_gnu_make_command='' ;
dnl Search all the common names for GNU make
! for a in "${MAKE-make}" make gmake gnumake ; do
if ( $a --version 2> /dev/null | grep -c GNU > /dev/null )
then
_cv_gnu_make_command=$a ;