This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[patch] to gcc: fix for an apparent bogus commit
- To: gcc-patches at gcc dot gnu dot org
- Subject: [patch] to gcc: fix for an apparent bogus commit
- From: msokolov at ivan dot Harhan dot ORG (Michael Sokolov)
- Date: Mon, 1 Jan 01 18:23:14 PST
Joern,
Your change to sdbout.c:
revision 1.34
date: 2000/09/18 20:00:58; author: amylaar; state: Exp; lines: +8 -3
branches: 1.34.2;
* sdbout.c (PUT_SDB_DEF, PUT_SDB_TAG, PUT_SDB_EPILOGUE_END):
Replace ASM_OUTPUT_LABELREF with assemble_name.
contains something that seems very bogus to me. Specifically, the above commit
includes the following hunk:
*************** static void sdbout_reg_parms PARAMS ((t
*** 161,169 ****
#ifndef PUT_SDB_DEF
#define PUT_SDB_DEF(a) \
do { fprintf (asm_out_file, "\t.def\t"); \
! ASM_OUTPUT_LABELREF (asm_out_file, a); \
fprintf (asm_out_file, SDB_DELIM); } while (0)
#endif
#ifndef PUT_SDB_PLAIN_DEF
--- 161,174 ----
#ifndef PUT_SDB_DEF
#define PUT_SDB_DEF(a) \
+
+ #undef PUT_SDB_DEF
+ PUT_SDB_DEF(a) \
+ char *a; {
do { fprintf (asm_out_file, "\t.def\t"); \
! assemble_name (asm_out_file, a); \
fprintf (asm_out_file, SDB_DELIM); } while (0)
+ ; }
#endif
#ifndef PUT_SDB_PLAIN_DEF
The added lines seem completely bogus to me. The resulting fragment doesn't
look like valid C to me, and the compiler screams at it. Was this just a bogus
commit? If so, would the patch below fix it?
--
Michael Sokolov
Public Service Agent
International Engineering and Science Task Force
1351 VINE AVE APT 27 Phone: +1-714-738-5409
FULLERTON CA 92833-4291 USA (home office)
E-mail: msokolov@ivan.Harhan.ORG (ARPA TCP/SMTP)
2001-01-01 Michael Sokolov <msokolov@ivan.Harhan.ORG>
* sdbout.c (PUT_SDB_DEF): Fix after last bogus change.
Index: sdbout.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/sdbout.c,v
retrieving revision 1.36
diff -p -r1.36 sdbout.c
*** sdbout.c 2000/10/20 19:17:41 1.36
--- sdbout.c 2001/01/02 02:08:27
*************** static void sdbout_reg_parms PARAMS ((t
*** 161,174 ****
#ifndef PUT_SDB_DEF
#define PUT_SDB_DEF(a) \
-
- #undef PUT_SDB_DEF
- PUT_SDB_DEF(a) \
- char *a; {
do { fprintf (asm_out_file, "\t.def\t"); \
assemble_name (asm_out_file, a); \
fprintf (asm_out_file, SDB_DELIM); } while (0)
- ; }
#endif
#ifndef PUT_SDB_PLAIN_DEF
--- 161,169 ----