This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Silence PPC+ARM preprocessor warnings in atomicity.h




Awesome. Please check this in. I posted my linux-ppc testresults here:

http://gcc.gnu.org/ml/libstdc++/2000-11/msg00419.html

If you could try to verify these results, CVS after your patch, and post 
your mkcheck.txt file to the libstc++ list I'd appreciate it.

It looks like x86/alpha/powerpc are now in sync, which is cool. I'm 
working on an arm cross compiler at the moment, but if you can post arm 
native results I'd appreciate it.

thanks,
benjamin

> The fix is simple and appended. I modeled the style after the alpha 
> atomicity.h. While I was at it, I fixed the ARM atomicity.h as well, with the 
> exception of the missing comments, since I'm not sure if /**/ makes a valid 
> assembler comment for ARM.
> 
> This patch brings back PPC to the state before the switch to libstdc++-v3/V3 
> ABI, with the exception of g++.pt/static11.C, which wasn't failing before:
> 
> FAIL: g++.ext/instantiate1.C not instantiated (test for errors, line 18)
> FAIL: g++.ext/instantiate1.C not instantiated (test for errors, line 20)
> FAIL: g++.other/loop2.C caused compiler crash
> FAIL: g++.pt/static11.C  Execution test
> 
> OK to commit?
> 
> Franz.
> 
>         * config/cpu/powerpc/bits/atomicity.h (__exchange_and_add): Silence
>         preprocessor multi-line string warnings.
>         (__atomic_add): Likewise.
>         (__compare_and_swap): Likewise.
>         (__always_swap): Likewise.
>         (__test_and_set): Likewise.
>         * config/cpu/arm/bits/atomicity.h (__exchange_and_add): Likewise.
>         (__atomic_add): Likewise.
>         (__compare_and_swap): Likewise.
>         (__always_swap): Likewise.
>         (__test_and_set): Likewise.
> 
> 

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]