Re: [PATCH]: Revised patch for fixinc on BeOS

[Bruce Korb <bkorb at sco dot COM>]

Daniel Berlin wrote:
> 
> This adds the BeOS specific makefile, as requested  by bruce.

Thanks :-)

Two nits below, otherwise looks ready for prime time to me.

> diff -c -3 -p -w -B -b -r1.42 fixincl.c
> *** fixincl.c   2000/11/17 04:16:55     1.42
> --- fixincl.c   2000/11/27 21:54:46

> --- 1421,1434 ----
>       }
> 
>     read_fd = open( pz_temp_file, O_RDONLY );
> +   if (read_fd > 0)
> +   {
>           test_for_changes( read_fd );
>           /* Unlinking a file while it is still open is a Bad Idea on
>              DOS/Windows.  */
>           close( read_fd );
>           unlink( pz_temp_file );
> !   }
>   # endif
>     UNLOAD_DATA();
>   }

I would still like to see an abort here.  I'll fix it later
if you do not.

nc.sh
> ===================================================================
> RCS file: /cvs/gcc/egcs/gcc/fixinc/mkfixinc.sh,v
> retrieving revision 1.28
> diff -c -3 -p -w -B -b -r1.28 mkfixinc.sh
> *** mkfixinc.sh 2000/11/17 23:48:15     1.28
> --- mkfixinc.sh 2000/11/27 21:54:48
> *************** case $machine in
> *** 35,40 ****
> --- 35,43 ----
>         i?86-*-openbsd*)
>                 fixincludes=fixinc.wrap
>                 ;;
> +       *-*-beos*)
> +               MAKE="${MAKE} -f ${srcdir}/Makefile.BEOS"
> +               ;;
> 
>         alpha*-*-winnt* | \
>         i?86-*-winnt3*)
> *************** case $machine in
> *** 55,61 ****
>         hppa1.1-*-bsd* | \
>         hppa1.0-*-bsd* | \
>         hppa*-*-lites* | \
> !       *-*-beos* | \
>         *-*-gnu* | \
>         i?86-moss-msdos* | i?86-*-moss* | \
>         i?86-*-osf1* | \
> --- 58,64 ----
>         hppa1.1-*-bsd* | \
>         hppa1.0-*-bsd* | \
>         hppa*-*-lites* | \
> !       *-*-linux* | \
>         *-*-gnu* | \
>         i?86-moss-msdos* | i?86-*-moss* | \
>         i?86-*-osf1* | \

Please do not add back ``linux'' here  :-)