This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: this patch still not apply
- To: lfarkas at mindmaker dot hu
- Subject: Re: this patch still not apply
- From: Gabriel Dos Reis <gdr at codesourcery dot com>
- Date: 17 Nov 2000 06:26:33 +0100
- Cc: STDC++ <libstdc++ at sources dot redhat dot com>, gcc-patches at gcc dot gnu dot org
- Organization: CodeSourcery, LLC
- References: <3A13BF18.96D6913E@mindmaker.hu>
Levente Farkas <lfarkas@mindmaker.hu> writes:
| hi,
| this patch still not apply:
| http://sources.redhat.com/ml/libstdc++/2000-11/msg00001.html
* include/bits/std_bitset.h (_M_do_find_first): Define as inline
function, since this function is fully specialized and in header
file. This function should have to be a __STL_TEMPLATE_NULL but
there is a gcc bug, so I put it into a comment.
(_M_do_find_next): Same.
The ChangLog entry is inaccurate althought the patch is technically
correct: the definition of the member function
_Base_bitset<1>::_M_do_find_first() is not a specialization. It is a
definition of a member function of a class template specialization, or
in English it is not an explicit specialization. So there is no bug
in GCC in that respect. Is the followiing entry OK with you?
* include/bits/std_bitset.h (_M_do_find_first): Define as inline
function. Remove __STL_TEMPLATE_NULL since this definition is
not a specialization.
(_M_do_find_next): Likewise.
-- Gaby
CodeSourcery, LLC http://www.codesourcery.com