This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: IRIX fixincludes
>>>>> "Zack" == Zack Weinberg <zackw@stanford.edu> writes:
Zack> On Sat, Nov 11, 2000 at 06:50:35PM -0800, Mark Mitchell
Zack> wrote:
>> The IRIX build was broken by the wchar_t stuff.
>>
>> I switched IRIX to ordinary fixincludes which fixed the
>> bootstrap. Some 96 files got fixed, with `machine_name' being
>> the most common fix.
Zack> Can you send me off-list a diff between /usr/include and the
Zack> fixed tree?
Done. Thanks for looking at them.
machine_name is a popular mistake to have in
Zack> system headers (it goes after "#ifdef irix" and the like);
Zack> on the other hand, it's also kinda fragile.
Right. On IRIX, it's `#ifdef sgi' that appears in a lot of the
headers.
>> This suggests that either our fixincludes stuff is too
>> aggressive -- or more likely that the IRIX headers really need
>> a good bit of fixing. I have a feeling we're going to be
>> moving away from the special-purpose fixincludes...
Zack> I think this is a good idea in any case. The fewer
Zack> different possibilities, the better.
Agreed. I don't see the point in the special-purpose files. We can
always conditionalize the fixes themselves to operate only on certain
systems, if that's what we really want.
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com